Mirrors/gomuks
1
0
Fork 1
mirror of https://github.com/tulir/gomuks.git synced 2025-04-19 18:13:41 -05:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

web/settings: allow editing string fields

Browse source
This commit is contained in:
Tulir Asokan 2024-12-02 16:44:48 +02:00
parent 68385fef5d
commit 09a586df3e
2 changed files with 41 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
web/src/ui/settings/SettingsView.css
View file

@ -14,8 +14,23 @@ div.settings-view {
table {
text-align: left;
tr {
height: 2.5rem;
}
div.preference {
display: flex;
&.select-preference > select {
padding: .25rem;
}
&.string-preference > input {
border: 1px solid var(--border-color);
padding: .25rem;
/* TODO make this less hacky */
width: 8rem;
}
}
}

28
web/src/ui/settings/SettingsView.tsx
View file

@ -54,6 +54,16 @@ const BooleanPreferenceCell = ({ context, name, setPref, value, inheritedValue }
</div>
}
const TextPreferenceCell = ({ context, name, setPref, value, inheritedValue }: PreferenceCellProps<string>) => {
const onChange = useCallback((evt: React.ChangeEvent<HTMLInputElement>) => {
setPref(context, name, evt.target.value)
}, [setPref, context, name])
return <div className="preference string-preference">
<input value={value ?? inheritedValue} onChange={onChange}/>
{useRemover(context, setPref, name, value)}
</div>
}
const SelectPreferenceCell = ({ context, name, pref, setPref, value, inheritedValue }: PreferenceCellProps<string>) => {
const onChange = useCallback((evt: React.ChangeEvent<HTMLSelectElement>) => {
setPref(context, name, evt.target.value)
@ -83,11 +93,16 @@ interface PreferenceRowProps {
roomLocal?: PreferenceValueType
}
const customUIPrefs = new Set([
"custom_css",
"custom_notification_sound",
] as (keyof Preferences)[])
const PreferenceRow = ({
name, pref, setPref, globalServer, globalLocal, roomServer, roomLocal,
}: PreferenceRowProps) => {
const prefType = typeof pref.defaultValue
if (prefType !== "boolean" && !pref.allowedValues) {
if (customUIPrefs.has(name)) {
return null
}
const makeContentCell = (
@ -104,7 +119,7 @@ const PreferenceRow = ({
value={val as boolean | undefined}
inheritedValue={inheritedVal as boolean}
/>
} else if (typeof prefType === "string" && pref.allowedValues) {
} else if (pref.allowedValues) {
return <SelectPreferenceCell
name={name}
setPref={setPref}
@ -113,6 +128,15 @@ const PreferenceRow = ({
value={val as string | undefined}
inheritedValue={inheritedVal as string}
/>
} else if (prefType === "string") {
return <TextPreferenceCell
name={name}
setPref={setPref}
context={context}
pref={pref as Preference<string>}
value={val as string | undefined}
inheritedValue={inheritedVal as string}
/>
} else {
return null
}