From 15238b66f9e5e9b8873ec11b3ec99f6c0854898a Mon Sep 17 00:00:00 2001 From: Tulir Asokan Date: Fri, 24 Jan 2025 01:47:03 +0200 Subject: [PATCH] web/timeline: fix clicking spoilers and summaries on mobile --- web/src/ui/timeline/TimelineEvent.tsx | 2 ++ web/src/ui/timeline/content/TextMessageBody.tsx | 2 ++ 2 files changed, 4 insertions(+) diff --git a/web/src/ui/timeline/TimelineEvent.tsx b/web/src/ui/timeline/TimelineEvent.tsx index 23efe9c..f4a7ae8 100644 --- a/web/src/ui/timeline/TimelineEvent.tsx +++ b/web/src/ui/timeline/TimelineEvent.tsx @@ -106,6 +106,8 @@ const TimelineEvent = ({ evt, prevEvt, disableMenu, smallReplies, isFocused }: T if ( targetElem.tagName === "A" || targetElem.tagName === "IMG" + || targetElem.tagName === "VIDEO" + || targetElem.tagName === "SUMMARY" ) { return } diff --git a/web/src/ui/timeline/content/TextMessageBody.tsx b/web/src/ui/timeline/content/TextMessageBody.tsx index 03cfdd2..6002d86 100644 --- a/web/src/ui/timeline/content/TextMessageBody.tsx +++ b/web/src/ui/timeline/content/TextMessageBody.tsx @@ -58,9 +58,11 @@ const onClickHTML = (evt: React.MouseEvent) => { } else if (targetElem.closest?.("span.hicli-spoiler")?.classList.toggle("spoiler-revealed")) { // When unspoilering, don't trigger links and other clickables inside the spoiler evt.preventDefault() + evt.stopPropagation() } else if (isAnchorElement(targetElem) && targetElem.href.startsWith("matrix:")) { onClickMatrixURI(targetElem.href) evt.preventDefault() + evt.stopPropagation() } }